Skip to content

Fail all activations when it fails to pull a blackbox image. #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2022
Merged

Fail all activations when it fails to pull a blackbox image. #5270

merged 3 commits into from
Jul 15, 2022

Conversation

style95
Copy link
Member

@style95 style95 commented Jul 9, 2022 •
edited
Loading

Description

Currently, if the system fails to pull a black-box image, it keeps waiting for the runtime pod to be running.

$ kubectl get pods
...
wsk-blue-test-invoker-38-47-style95-dockeraction     0/1     ImagePullBackOff   0          41h
wsk-blue-test-invoker-38-48-style95-dockeraction     0/1     ImagePullBackOff   0          41h
...

If the pod creation is failed due to image pulling, we can complete activations with an error.
Another case is a black-box pod is failed to run because a command is not found.
In such cases, the system can let users know about the issues in their images.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022 •
edited
Loading

Codecov Report

Merging #5270 (25dc3da) into master (639c4a9) will increase coverage by 4.78%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #5270      +/-   ##
==========================================
+ Coverage   70.36%   75.14%   +4.78%     
==========================================
  Files         238      238              
  Lines       14084    14092       +8     
  Branches      588      601      +13     
==========================================
+ Hits         9910    10590     +680     
+ Misses       4174     3502     -672
Impacted Files Coverage Δ
...cala/org/apache/openwhisk/http/ErrorResponse.scala 89.10% <0.00%> (-0.90%) ⬇️
...sk/core/containerpool/docker/DockerContainer.scala 95.60% <ø> (ø)
...containerpool/kubernetes/KubernetesContainer.scala 88.00% <ø> (ø)
...re/containerpool/kubernetes/KubernetesClient.scala 38.34% <71.42%> (+0.90%) ⬆️
...in/scala/org/apache/openwhisk/common/Logging.scala 79.38% <100.00%> (+1.41%) ⬆️
...whisk/core/containerpool/docker/DockerClient.scala 96.36% <100.00%> (ø)
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639c4a9...25dc3da. Read the comment docs.

@style95 style95 force-pushed the image-pull-error branch from 17c89c4 to 5e63c85 Compare July 9, 2022 12:41
@style95 style95 mentioned this pull request Jul 11, 2022
Merged
@ningyougang
Copy link
Contributor

LGTM

@style95 style95 merged commit f03cbcc into apache:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ningyougang ningyougang ningyougang approved these changes

@bdoyle0182 bdoyle0182 Awaiting requested review from bdoyle0182

@KeonHee KeonHee Awaiting requested review from KeonHee

@upgle upgle Awaiting requested review from upgle

@jiangpengcheng jiangpengcheng Awaiting requested review from jiangpengcheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@style95 @codecov-commenter @ningyougang